Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dotnet enhancement #1539

Merged
merged 24 commits into from
Jul 1, 2022

Conversation

serena-ruan
Copy link
Contributor

@serena-ruan serena-ruan commented Jun 21, 2022

Summary

Add some enhancement to dotnet codegen system

Tests

Local & pipeline tests.

Dependency changes

None.

AB#1838818

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #1539 (0e3681d) into master (7f9eaec) will increase coverage by 0.01%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   83.71%   83.73%   +0.01%     
==========================================
  Files         301      301              
  Lines       15369    15378       +9     
  Branches      713      686      -27     
==========================================
+ Hits        12866    12876      +10     
+ Misses       2503     2502       -1     
Impacted Files Coverage Δ
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 74.46% <ø> (ø)
...osoft/azure/synapse/ml/codegen/DotnetCodegen.scala 80.76% <75.00%> (-1.84%) ⬇️
...re/synapse/ml/cognitive/CognitiveServiceBase.scala 77.62% <100.00%> (+0.31%) ⬆️
...ft/azure/synapse/ml/cognitive/TextTranslator.scala 81.20% <100.00%> (ø)
...oft/azure/synapse/ml/codegen/DotnetWrappable.scala 89.13% <100.00%> (+0.49%) ⬆️
...ft/azure/synapse/ml/param/JsonEncodableParam.scala 64.28% <100.00%> (ø)
...spark/ml/recommendation/RecommendationHelper.scala 67.10% <100.00%> (ø)
...se/ml/cognitive/MultivariateAnomalyDetection.scala 87.77% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9eaec...0e3681d. Read the comment docs.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Jun 21, 2022
@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

1 similar comment
@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan marked this pull request as ready for review July 1, 2022 06:26
@serena-ruan serena-ruan requested a review from eisber as a code owner July 1, 2022 06:26
@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit becab1f into microsoft:master Jul 1, 2022
@serena-ruan serena-ruan deleted the serena/enhanceDotnet branch July 4, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants