fix: remove exclusion for ExplanationDashboard notebook #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1531 +/- ##
==========================================
- Coverage 84.30% 84.20% -0.10%
==========================================
Files 297 290 -7
Lines 14954 14819 -135
Branches 719 719
==========================================
- Hits 12607 12479 -128
+ Misses 2347 2340 -7
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
previously approved these changes
Jun 16, 2022
core/src/test/scala/com/microsoft/azure/synapse/ml/nbtest/SynapseTests.scala
Show resolved
Hide resolved
core/src/test/scala/com/microsoft/azure/synapse/ml/nbtest/SynapseTests.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug that allows Interpretability - Explaination Dashboard notebook runnable on SynapseE2E Tests. This PR also has some nit fixes for rest of the code.
Tests
Ran SynapseE2E Tests locally to verify
Dependency changes
Updated
com.linkedin.isolation-forestfrom version2.0.8to version3.0.0Added dependency of IPython for notebooks as they use it for
pip installcommandsAB#1832365