fix: repartition bug in LightGBMRanker #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
approved these changes
Jan 26, 2022
| df.count | ||
| df | ||
| } | ||
| case Some(groupingCol) => |
There was a problem hiding this comment.
I recall this logic was modified in this PR from another user for the ranker:
#778
who had issues with this logic, so I would just be careful here
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
- Coverage 84.77% 84.69% -0.09%
==========================================
Files 287 287
Lines 14230 14234 +4
Branches 732 729 -3
==========================================
- Hits 12064 12055 -9
- Misses 2166 2179 +13
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1336 fix repartition bug in LightGBMRanker