Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Interface implements Interface Syntax #654

Closed
iddan opened this issue Jun 16, 2020 · 2 comments
Closed

Support Interface implements Interface Syntax #654

iddan opened this issue Jun 16, 2020 · 2 comments
Labels
Duplicate 🔑 This issue or pull request already exists Enhancement 🆕 New feature or request

Comments

@iddan
Copy link

iddan commented Jun 16, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Now that RFC: Allow interfaces to implement other interfaces is merged interfaces should allow implementing other interfaces.

Describe the solution you'd like
Add implements property to InterfaceTypeSettings.

@InterfaceType()
abstract class Node {}

@InterfaceType({ implements: [Node] })
abstract class Furniture extends Node {}

Which will generate:

interface Node {}

interface Furniture implements Node {}
@MichalLytek
Copy link
Owner

It's already implemented in #602 and available in v1.0.0-rc.2.

@MichalLytek MichalLytek added Duplicate 🔑 This issue or pull request already exists Enhancement 🆕 New feature or request labels Jun 17, 2020
@iddan
Copy link
Author

iddan commented Jun 17, 2020

Sorry, missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate 🔑 This issue or pull request already exists Enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichalLytek @iddan