object.assign called with boolean argument

[arolson101]

Describe the bug
When I run a query in react-native I get the following:

TypeError: In this environment the sources for assign MUST be an object. This error is a performance optimization and not spec compliant.
    at Object.assign

the problem is in type-graphql/src/resolvers/validate-arg.ts:

import { validateOrReject, ValidatorOptions } from "class-validator";

import { ArgumentValidationError } from "../errors/ArgumentValidationError";

export async function validateArg<T extends Object>(
  arg: T | undefined,
  globalValidate: boolean | ValidatorOptions,
  argValidate?: boolean | ValidatorOptions,
): Promise<T | undefined> {
  const validate = argValidate !== undefined ? argValidate : globalValidate;
  if (validate === false || arg == null || typeof arg !== "object") {
    return arg;
  }

  const validatorOptions: ValidatorOptions = Object.assign({}, globalValidate, argValidate);
  if (validatorOptions.skipMissingProperties !== false) {
    validatorOptions.skipMissingProperties = true;
  }

  try {
    await validateOrReject(arg, validatorOptions);
    return arg;
  } catch (err) {
    throw new ArgumentValidationError(err);
  }
}

in this case globalValidate is true and argValidate is undefined

I think it's reasonable to request that Object.assign not be called with boolean arguments. Perhaps:

const validatorOptions: ValidatorOptions = Object.assign({}, (typeof globalValidate === 'object' ? globalValidate : {}), (typeof argValidate) === 'object' ? argValidate : {}));

To Reproduce
A quick guide how to reproduce the bug.
You can paste here code snippets or even better, provide a link to the repository with minimal reproducible code example.

Run under react-native. The relevant code is in the polyfill for object.assign in Object.es6.js:

  for (var nextIndex = 1; nextIndex < arguments.length; nextIndex++) {
    var nextSource = arguments[nextIndex];
    if (nextSource == null) {
      continue;
    }

    if (__DEV__) {
      if (typeof nextSource !== 'object' &&
          typeof nextSource !== 'function') {
        throw new TypeError(
          'In this environment the sources for assign MUST be an object. ' +
          'This error is a performance optimization and not spec compliant.'
        );
      }
    }`

Expected behavior
no error

Logs
If applicable, add some console logs to help explain your problem.
You can paste the errors with stack trace that were printed when the error occured.

Enviorment (please complete the following information):

• OS: android
• Node 8.11.2
• Package version: 0.12.2
• TypeScript version 2.9.2

Additional context

[MichalLytek]

Honestly, I've never considered React Native as a platform for TypeGraphQL.
What is you use case that you run GraphQL server inside a mobile app?

The fix is easy, so I will do that in a minute 😉

[arolson101]

I find graphql to be a good way to access the local database inside my mobile app. React doesn’t really have any good way to handle async data fetches- it’s all redux saga or redux-thunk, and all I want to do is fetch some data that is local state for a component and not make things complicated.

[arolson101]

And thank you!

[MichalLytek]

fixed via af742d8, released in v0.12.3 🎉