GitHub branch protections with queues

[ghost]

👋🏻

New comer to using mergify and potentially unique requirements, however... I'd like to propose the discussion about moving/configuring the GitHub branch protection checks that mergify upholds.

Currently, the rules are added to the pull_request_rules.conditions causing PRs not to be added to the queue unless they fulfil these extra rules. However, since our CI can take considerable time, it is useful for us to add PRs into the queue (and therefore rebase them to keep them up-to-date) purely based on the mergify conditions and enforce the branch protections rules at merge time (queue_rules.conditions).

We investigation removing the GitHub branch protection rules and enforcing everything in mergify but GitHub does not offer a way to prevent our users from manually pressing the merge button in a PR.

queue_rules:
  - name: default
    conditions:
      - "#approved-reviews-by>=1"

pull_request_rules:
  - name: lgtm-default
    conditions:
      - "base=master"
      - "label=LGTM"
    actions:
      queue:
        name: default
        update_method: rebase

[sileht]

Hi @rjinskidepop,

You can't use the Summary as it's always green (except if the configuration file is invalid).

But what users do in general is only allow Mergify[bot] (and maybe a couple of super people) to push the Merge button, with the branch protection settings Restrict who can push to matching branches (https://docs.mergify.io/faq/#mergify-is-unable-to-merge-my-pull-request-due-to-my-branch-protection-settings).

[ghost]

Unfortunately, I have tried that but it doesn't actually restrict who can press the button manually as most of our users are one of "Organization administrators, repository administrators, and users with the Maintain role."

It would be useful in mergify to have an option to disable waiting for GitHub branch protection rules before a PR can enter a queue.

[jd]

It would be useful in mergify to have an option to disable waiting for GitHub branch protection rules before a PR can enter a queue.

That sounds like a good idea. We've added this on our roadmap.

[jd]

This is now implemented with require_branch_protection in the queue action.

[ghost]

🚀 👏🏻