-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SRGAN and datamodules for super resolution #466
Add SRGAN and datamodules for super resolution #466
Conversation
Hello @chris-clem! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-12 07:10:48 UTC |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
======================================
+ Coverage 73% 74% +1%
======================================
Files 128 134 +6
Lines 8461 8244 -217
======================================
- Hits 6193 6102 -91
+ Misses 2268 2142 -126 |
…412_srgan # Conflicts: # pl_bolts/models/gans/srgan/srgan_module.py
# Conflicts: # CHANGELOG.md # pl_bolts/callbacks/__init__.py # pl_bolts/callbacks/vision/__init__.py # pl_bolts/models/gans/__init__.py
…orch-lightning-bolts into feature/412_srgan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-clem Hi, thanks for reminding me of this issue. I had a look at all the failing tests, and am sure that they are all irrelevant to the change in this PR :]
@Borda @akihironitta Should I fix the CodeFactor and DeepSource issues? |
I think it is fine :] just adding back mypy typing... #776 |
What does this PR do?
Adds a SRGAN implementation to bolts as proposed in #412.
Closes #412
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃