-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cityscapes DataModule + clean up DM docs #136
Add Cityscapes DataModule + clean up DM docs #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 91.32% 91.30% -0.03%
==========================================
Files 86 84 -2
Lines 4174 4049 -125
==========================================
- Hits 3812 3697 -115
+ Misses 362 352 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Due to technical reasons (uncorrelated with this PR) I'm unable to test this, can somebody please try it out? |
Awesome.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, just add Docs and source reference
This pull request is now in conflict... :( |
@InCogNiTo124 awesome PR! Looking forward to more datamodules :) |
Before submitting
What does this PR do?
Fixes #135.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃