Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the same ranges for all platforms #453

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Implement the same ranges for all platforms #453

wants to merge 14 commits into from

Conversation

dkhalanskyjb
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb commented Oct 31, 2024 •
edited
Loading

Fixes #432

lukellmann
lukellmann reviewed Nov 1, 2024
View reviewed changes
core/common/src/LocalDate.kt Outdated Show resolved Hide resolved
core/common/src/LocalDate.kt Outdated Show resolved Hide resolved
@dkhalanskyjb dkhalanskyjb force-pushed the uniform-ranges branch 3 times, most recently from b7c293c to ae4373e Compare November 5, 2024 12:52
@dkhalanskyjb dkhalanskyjb marked this pull request as ready for review November 5, 2024 12:52
@dkhalanskyjb dkhalanskyjb requested a review from ilya-g November 5, 2024 12:52
@dkhalanskyjb dkhalanskyjb mentioned this pull request Nov 13, 2024
Draft
qurbonzoda
qurbonzoda reviewed Nov 17, 2024
View reviewed changes
core/common/src/LocalDate.kt Show resolved Hide resolved
core/common/src/LocalDate.kt Outdated Show resolved Hide resolved
core/common/src/DateTimePeriod.kt Outdated Show resolved Hide resolved
qurbonzoda
qurbonzoda reviewed Nov 18, 2024
View reviewed changes
core/commonJs/src/internal/Platform.kt Outdated Show resolved Hide resolved
core/commonJs/src/internal/Platform.kt Outdated Show resolved Hide resolved
core/js/src/PlatformSpecifics.kt Show resolved Hide resolved
core/commonJs/src/internal/Platform.kt Show resolved Hide resolved
core/commonJs/src/internal/Platform.kt Outdated Show resolved Hide resolved
qurbonzoda
qurbonzoda reviewed Nov 18, 2024
View reviewed changes
core/commonJs/src/internal/Platform.kt Outdated Show resolved Hide resolved
core/commonJs/src/internal/Platform.kt Outdated Show resolved Hide resolved
core/commonJs/src/internal/Platform.kt Show resolved Hide resolved
qurbonzoda
qurbonzoda reviewed Nov 18, 2024
View reviewed changes
core/commonKotlin/src/TimeZone.kt Outdated Show resolved Hide resolved
core/wasmJs/src/PlatformSpecifics.kt Outdated Show resolved Hide resolved
core/commonKotlin/src/Instant.kt Outdated Show resolved Hide resolved
core/commonKotlin/src/Instant.kt Outdated Show resolved Hide resolved
ilya-g
ilya-g reviewed Dec 3, 2024
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
core/common/src/DateTimePeriod.kt Outdated Show resolved Hide resolved
core/common/src/LocalDate.kt Outdated Show resolved Hide resolved
core/common/test/InstantTest.kt Outdated Show resolved Hide resolved
core/common/test/InstantTest.kt Outdated Show resolved Hide resolved
@dkhalanskyjb dkhalanskyjb requested a review from ilya-g December 9, 2024 13:26
@dkhalanskyjb dkhalanskyjb mentioned this pull request Dec 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukellmann lukellmann lukellmann left review comments

@qurbonzoda qurbonzoda qurbonzoda approved these changes

@ilya-g ilya-g Awaiting requested review from ilya-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make admissible ranges the same on all platforms
4 participants
@dkhalanskyjb @ilya-g @qurbonzoda @lukellmann