Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Possible collaboration: upcoming package FlameGraphs.jl for profiling #452

Closed
timholy opened this issue Jan 15, 2020 · 1 comment · Fixed by JunoLab/Atom.jl#244
Closed

Comments

@timholy
Copy link
Contributor

timholy commented Jan 15, 2020

I've seen a number of complaints that profiling is still not ideal in Julia. My own package, ProfileView, probably contributed to that problem: it was written in the Julia 0.1 days and hadn't had a fundamental architecture update. Consequently it has a number of limitations.

En route to fixing some of those limitations, I decided to split it into 4 packages:

  • LeftChildRightSiblingTrees was used for internal data handling. The details aren't terribly special (any k-ary tree structure would do equally well), but I cleaned it up and made it a standalone package.
  • FlameGraphs: handles the computational side of producing a flamegraph.
  • ProfileSVG and ProfileView will be visualization/export functionality (linked from the FlameGraphs README)

I don't know whether you're wishing for anything more from your profiling, but if so perhaps we could collaborate at the level of FlameGraphs.jl as it's GUI-agnostic. The dev (but not stable) docs have just built and been hosted, so you can read more about it if you want.

EDIT: FlameGraphs.jl is not yet registered but that might change in 3 days: JuliaRegistries/General#7997

@pfitzseb
Copy link
Member

FlameGraphs.jl makes things really easy for us indeed., thanks! :)

At some point it might make sense to create a common web-frontend based on e.g. flamebearer (although there probably are better choices) to get around the performance problems with Juno's and, probably, ProfileSVGs implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants