-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Decouple progress frontend #400
Comments
Yes, definitely.
It isn't for Juno's implementation -- any logging level higher or equal to |
OK, I created https://github.com/tkf/ProgressLogging.jl. Do you want to move it to https://github.com/JunoLab? |
Sure, why not -- invited you to the org. Thanks for splitting out the code! |
I got a permission error when I tried to transfer it to JunoLab so I transferred the repository to you. Can you move it to JunoLab? |
Hm, weird. Should be transferred now. |
Thanks! |
IIUC, due to Juno-specific check in
@progress
macro implementation, code using@progress
can only work inside Juno:Juno.jl/src/progress.jl
Lines 105 to 106 in 554707e
The specification in
Juno.progress
docstring also does not specify that usingLogLevel(-1)
is crucial.These are issues I noticed while writing a ProgressMeter-Logging bridge ProgressMeterLogging.jl and adding a frontend support in my package JuliaFolds/Transducers.jl#63. I think a cleaner solution may be having a base package with a spec and a reference implementation of frontend progress macros and functions.
What do you think? Is it a good approach to decouple progress logging interface (frontend API and specification documentation) from Juno?
The text was updated successfully, but these errors were encountered: