[BUG] Inline evaluation very slow with some workspace pane contents

[yha]

Details

• Atom version: 1.40.1 x64
• Julia version: 1.1.1
• OS: Windows 10
• Package versions:
  • Atom.jl: 0.10.1
  • julia-client: 0.10.1
  • ink: 0.11.0

Steps to reproduce

The smallest reproducing example I could find is still pretty complex. Step through the following with the workspace pane open:

using TestImages

n = 100    # no bug for n = 10
lighthouse = testimage("lighthouse");
frames = [lighthouse for _=1:n]
function f()
    cache = Dict()
    i -> get!(cache, i) do
        try
            frame = frames[i]
        catch e
            e
        end
    end
end

g = f()
e = g(n+1);
"foo"

The inline display of "foo" takes about a minute to show, and subsequent inline displays are equally slow.

[pfitzseb]

So is frames the problem here? I can't repro this on Atom.jl master, so I think this is fixed.

[yha]

I can reproduce here with Atom#master as well.

So is frames the problem here?

The problem disappears when frames is smaller. But it also disappears with various other changes, such as if the exception is not triggered (g(n) instead of g(n+1)), or if a different exception is returned which doesn't point into frames, or if the closure is not assigned to a variable (e=f()(n+1)) (or when the workspace pane is closed, as I mentioned).

[pfitzseb]

Hm, weird. This is what it looks like for me with n = 1000:

[yha]

Here's what I see. Evaluation of "foo" takes about 40 seconds here. If I don't stop at the g=f() line, it's stuck already at the next line.

I've also reproduced this on another machine.

[pfitzseb]

Ok, turns out this problem is very specific to Julia 1.1. Turns out that string(g) prints everything it closes over, including frames...

Fixed with JunoLab/Atom.jl@0d5ec76.