Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use disable_sigint instead of sigatomic_(begin|end) #684

Closed
tkf opened this issue Apr 30, 2019 · 0 comments · Fixed by #686
Closed

Use disable_sigint instead of sigatomic_(begin|end) #684

tkf opened this issue Apr 30, 2019 · 0 comments · Fixed by #686

Comments

@tkf
Copy link
Member

tkf commented Apr 30, 2019

disable_sigint is the public API so we better use it instead of sigatomic_(begin|end).

A side effect is that it makes PyCall work with JuliaInterpreter.jl ouf-of-the-box and avoid issues like https://discourse.julialang.org/t/23560 and JuliaDebug/JuliaInterpreter.jl#219. This is because JuliaInterpreter.jl uses disable_sigint to workaround the issues related to the signal handler JuliaDebug/JuliaInterpreter.jl#108.

@stevengj Repeating what I asked in #683:

@stevengj You didn't want to put disable_sigint for all ccall #574 (comment) but maybe replacing only the sigatomic_begin-sigatomic_end pairs is OK?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use disable_sigint instead of sigatomic_(begin|end) tkf/PyCall.jl
1 participant
@tkf