-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A question about supported platforms #657
Comments
Hi @BoD, I need to publish different versions because the binary compatibility of some JS-related classes was broken in version 231. As a result, a plugin compiled with 231 EAP won't work with earlier versions. AFAIK, you can't specify an exact version of a plugin dependency in a plugin manifest. However, you can try compiling with the latest 231 EAP and version 4.0.0 of the GraphQL plugin. Then, check that it works with 222 IDEA with 4.0.0-222 GraphQL plugin installed. Loading graphql.config.js should not cause any exceptions. If it works, that means everything is okay. When you will be ready to release your plugin, I can also check it if you want. |
Thanks a lot for replying!
Oooh I see, so you basically had to exclude 231.
That makes sense, thank you! I was confused by the 2 different kind of dependencies (compilation/gradle, which is versioned, vs manifest which is not). Thanks a lot, it looks like what you say will work (I'm getting verifier errors, but that's a separate issue). |
Hi! I see that 2 versions of the plugin are published:
master
branch:222
branch:As of today,
222
, and the latest Android Studio Canary (Giraffe) is223
.231
Therefore
4.0.0-222
doesn't support Idea Stable because of itsUntil
, and4.0.0
doesn't support Android Studio Stable because of itsSince
.Therefore, as the author of a plugin that depends on the GraphQL plugin, and trying to support both Android Studio and Idea,I can't depend on either
4.0.0
nor4.0.0-222
, I think I will also need to have 2 versions: one that depends on4.0.0
, and one that depends on4.0.0-222
.Diffing the
master
and222
branches, it looks to me that there are no code differences, correct? If I understand correctly, this means that there could be only one published version withpluginSinceBuild=222.0
andpluginUntilBuild=233.*
, which would simplify things.Am I missing anything? Thanks!
The text was updated successfully, but these errors were encountered: