Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on VS Code's proposed webview API #166

Closed
mjbvz opened this issue Feb 16, 2018 · 0 comments
Closed

Feedback on VS Code's proposed webview API #166

mjbvz opened this issue Feb 16, 2018 · 0 comments

Comments

@mjbvz
Copy link

mjbvz commented Feb 16, 2018

I'm on the VS Code team and am investigating adding a new API for managing webviews. As your extension already is using webviews through the html preview, I'd like your feedback on our proposal.

You can find the first cut of new api here. It supersedes TextDocumentContentProvider and will hopefully make creating and working with webviews easier. It also adds a few important security improvements that will better protect users even if a webview accidentally allows untrusted content injection.

To try the new API:

  1. Add "enableProposedApi": true to your package.json
  2. Manually download vscode.proposed.d.ts and add it to your project: https://raw.githubusercontent.com/Microsoft/vscode/master/src/vs/vscode.proposed.d.ts
  3. Run your extension with the latest VS Code insiders build

VS Code's markdown preview is already using this new API. We're still iterating on the API so the specifics may change. microsoft/vscode#43713 tracks this work on our side

Please take a look at the new webview API and let me know if you have any questions or suggestions.

@Huachao Huachao closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants