Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Missing smart actions and smart targets #38

Open
aletson opened this issue Oct 16, 2017 · 3 comments
Open

Missing smart actions and smart targets #38

aletson opened this issue Oct 16, 2017 · 3 comments

Comments

@aletson
Copy link

aletson commented Oct 16, 2017

Keira2 has missing or out of date actions and targets compared to current commit of TrinityCore.

See this gist for all current actions and targets formatted for Keira2

I haven't done the labels for the specific fields, unfortunately, haven't had the time.

@FrancescoBorzi
Copy link
Collaborator

which date actions are missing?

@aletson
Copy link
Author

aletson commented Oct 16, 2017

Sorry for not specifying, I'll run a proper diff as soon as I'm back at a computer this evening

@aletson
Copy link
Author

aletson commented Oct 16, 2017

action_type 7 should be OFFER_QUEST
action_type 27 should be COMBAT_STOP
action_type 46 is no longer set in TC (UNUSED_46 perhaps?)
action_type 60 should be SET_DISABLE_GRAVITY
from action_type 111 to 132, should be:

app.saiLabels.action_type.name[111] = "GAME_EVENT_STOP"; //replaces START_CLOSEST_WAYPOINT
app.saiLabels.action_type.name[112] = "GAME_EVENT_START";
app.saiLabels.action_type.name[113] = "START_CLOSEST_WAYPOINT";
app.saiLabels.action_type.name[114] = "MOVE_OFFSET";
app.saiLabels.action_type.name[115] = "RANDOM_SOUND";
app.saiLabels.action_type.name[116] = "SET_CORPSE_DELAY";
app.saiLabels.action_type.name[117] = "DISABLE_EVADE";
app.saiLabels.action_type.name[118] = "GO_SET_GO_STATE";
app.saiLabels.action_type.name[119] = "SET_CAN_FLY";
app.saiLabels.action_type.name[120] = "REMOVE_AURAS_BY_TYPE";
app.saiLabels.action_type.name[121] = "SET_SIGHT_DIST";
app.saiLabels.action_type.name[122] = "FLEE";
app.saiLabels.action_type.name[123] = "ADD_THREAT";
app.saiLabels.action_type.name[124] = "LOAD_EQUIPMENT";
app.saiLabels.action_type.name[125] = "TRIGGER_RANDOM_TIMED_EVENT";
app.saiLabels.action_type.name[126] = "REMOVE_ALL_GAMEOBJECTS";
app.saiLabels.action_type.name[127] = "STOP_MOTION";
app.saiLabels.action_type.name[128] = "PLAY_ANIMKIT";
app.saiLabels.action_type.name[129] = "SCENE_PLAY";
app.saiLabels.action_type.name[130] = "SCENE_CANCEL";
app.saiLabels.action_type.name[131] = "SPAWN_SPAWNGROUP";
app.saiLabels.action_type.name[132] = "DESPAWN_SPAWNGROUP";

targets: just the two new ones

app.saiLabels.target_type.name[28] = "FARTHEST";
app.saiLabels.target_type.name[29] = "VEHICLE_ACCESSORY";

I'm fairly sure events stayed the same.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants