Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for metadata size, index cache size and index cache page size for bloom filter index #5268

Open
CookiePieWw opened this issue Jan 2, 2025 · 2 comments
Labels
C-enhancement Category Enhancements

Comments

@CookiePieWw
Copy link
Collaborator

What type of enhancement is this?

Configuration

What does the enhancement do?

Currently bloom filter index and inverted index uses the same config for metadata size, content size and content page size in cache. We'd better set them separatly since they may be different IO size pattern.

Implementation challenges

No response

@CookiePieWw CookiePieWw added C-enhancement Category Enhancements good first issue Good for newcomers labels Jan 2, 2025
@CookiePieWw CookiePieWw changed the title Add config for index cache size and index cache page size for bloom filter index Add config for metadata size, index cache size and index cache page size for bloom filter index Jan 2, 2025
@evenyag evenyag removed the good first issue Good for newcomers label Jan 2, 2025
@evenyag
Copy link
Contributor

evenyag commented Jan 2, 2025

We may need further discussion on how to organize these cache configs. I prefer not exposing to many configs to users.

@CookiePieWw
Copy link
Collaborator Author

We may need further discussion on how to organize these cache configs. I prefer not exposing to many configs to users.

Got you. Currently the docs of the config only mentioned inverted index. Maybe we can update it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

2 participants