Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when labels map contains null values #4294

Closed
stefanLeo opened this issue Jul 31, 2024 · 2 comments
Closed

Improve error message when labels map contains null values #4294

stefanLeo opened this issue Jul 31, 2024 · 2 comments

Comments

@stefanLeo
Copy link

stefanLeo commented Jul 31, 2024

Environment:

Jib version: 3.4.3
Build tool: Maven 3.9.6
OS: N/A

Description of the issue:

Jib's checks if any of the keys and values set in the container.labels configuration is null, which is super helpful. However, the error message when an container.label value is null currently reads only like this: "labels map contains null values". For someone not so deep into Jib, this could be not enough of a hint to the actual problem.

Expected behavior:
The error message should contain the offending keys, for example like so: "labels map contains null values for key(s): FOO, BAR, BAZ"

Steps to reproduce:

Use an labels map with a value set to null
Run jib
@chanseokoh
Copy link
Member

Dup of #4263.

@zhumin8
Copy link
Contributor

zhumin8 commented Jul 31, 2024

closing as dup and track in #4263.

@zhumin8 zhumin8 closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants