Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO Audit Failure: link.href.toLowerCase is not a function #6481

Closed
cmoss3 opened this issue Nov 5, 2018 · 4 comments · Fixed by #6483
Closed

SEO Audit Failure: link.href.toLowerCase is not a function #6481

cmoss3 opened this issue Nov 5, 2018 · 4 comments · Fixed by #6483
Assignees
Labels

Comments

@cmoss3
Copy link

cmoss3 commented Nov 5, 2018

Provide the steps to reproduce

  1. Run LH on https://www.browardcriminalteam.com/

What is the current behavior?

The SEO portion of the audit is not passing, nor is it providing explanation.

Under the SEO portion of the audit results I see "Error!" in the top right corner.
When I hover over the text an error message is revealed: "Audit Error: link.href.toLowerCase is not a function"
Here is a snapshot for context: https://www.screencast.com/t/XESTDL0iW

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: 3.0.3
  • Operating System: Windows 10
@patrickhulce
Copy link
Collaborator

Thanks very much for reporting @cmoss3! It's the links inside SVG that are throwing this one :)

@cmoss3
Copy link
Author

cmoss3 commented Nov 6, 2018

@patrickhulce Thanks for looking into this! I guess I was assuming that if an aria-label attribute was available on the link, then that would be sufficient for links with images/graphics inside. Either way though, it definitely shouldn't be causing the SEO audit to fail. Thanks again!

@patrickhulce
Copy link
Collaborator

Agreed, definitely wasn't a commentary on the way it's setup! Just explaining why LH is barfing :)

This is actually a great point I'm not sure if search will use the aria-label if there's no text available...

@rviscomi do you know if search has a public position on this?

@rviscomi
Copy link
Member

rviscomi commented Nov 6, 2018

No I don't believe aria-label is used as a fallback to missing inner text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants