Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change performance group based on FR mode #12828

Closed
adamraine opened this issue Jul 26, 2021 · 2 comments · Fixed by #13241
Closed

Change performance group based on FR mode #12828

adamraine opened this issue Jul 26, 2021 · 2 comments · Fixed by #13241

Comments

@adamraine
Copy link
Member

#12814 (comment)

We need a way to change and audits group based on the FR mode to progress with
#12814. Specifically, it would be nice to relegate opportunities to the diagnostic group if they can't report any savings.

One option is to use the config to decide the audit group for different modes.

Another option I've been thinking about, optionally return overrideGroup in the audit to dynamically change the group.

@brendankenny
Copy link
Member

another option (from #12814 (comment)):

  • remove group: 'load-opportunities' and group: 'diagnostics' from the config and have perf audits be in the opportunities section if their audit details are type: 'opportunity', otherwise they're a diagnostic. Would require resurrecting some form of the "hidden" group (e6e4395) to keep the hidden perf audits hidden.

@patrickhulce
Copy link
Collaborator

Plan here is to follow @brendankenny 's suggestion of dynamic pulling but closer to v9 as it's fairly close to a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants