You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lighthouse is currently depending on exactly version 3.3.2 of ws, which is both out of date by a couple of majors and has a security vulnerability: https://npmjs.com/advisories/1748
It would be great if we could get this version bumped (ideally as a minor or patch version if possible), and the constraint relaxed to allow pulling in patch versions.
The min version that this would need to be lifted to for this advisory is v5 (released a few hours ago, so the advisory isn't yet updated with that), but the latest is v7:
The close status code is now set to 1005 if the received close frame contains
no status code (a31b1f6).
Error messages and types have been updated (695c5ea).
The onerror event handler now receives an ErrorEvent instead of JavaScript
error (63e275e).
The third argument of WebSocket.prototype.ping() and
WebSocket.prototype.pong() is no longer a boolean but an optional callback
(30c9f71).
The non-standard protocolVersion and bytesReceived attributes have been
removed (30c9f71...ee9b5f3).
The extensions attribute is no longer an object but a string representing
the extensions selected by the server (fdec524).
The 'headers' event on the client has been renamed to 'upgrade'. Listeners
of this event now receive only the response argument (1c783c2).
The WebSocket.prototype.pause() and WebSocket.prototype.resume() methods
have been removed to prevent the user from interfering with the state of the
underlying net.Socket stream (a206e98).
The text was updated successfully, but these errors were encountered:
lighthouse
is currently depending on exactly version3.3.2
ofws
, which is both out of date by a couple of majors and has a security vulnerability: https://npmjs.com/advisories/1748It would be great if we could get this version bumped (ideally as a minor or patch version if possible), and the constraint relaxed to allow pulling in patch versions.
The min version that this would need to be lifted to for this advisory is v5 (released a few hours ago, so the advisory isn't yet updated with that), but the latest is v7:
Breaking changes for v7:
(692d7b4).
readyState attribute is not OPEN (AMP and PWA how to run separate tests? #1532)
argument in bytes.
Breaking changes for v6:
browser (Extension Error: Failed to construct 'URL': Invalid URL #1345).
zlibDeflateOptions instead. (80e2002).
Breaking changes for v5:
the client's requested subprotocols (Extension Error: Failed to construct 'URL': Invalid URL #1312).
Breaking changes for v4:
no status code (a31b1f6).
error (63e275e).
WebSocket.prototype.pong() is no longer a boolean but an optional callback
(30c9f71).
removed (30c9f71...ee9b5f3).
the extensions selected by the server (fdec524).
of this event now receive only the response argument (1c783c2).
have been removed to prevent the user from interfering with the state of the
underlying net.Socket stream (a206e98).
The text was updated successfully, but these errors were encountered: