From 66f9e7bff7a7f33eb3f66312bbe6437b30653410 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Thu, 4 Mar 2021 14:33:47 -0600 Subject: [PATCH] core(errors-in-console): properly define default options --- lighthouse-core/audits/errors-in-console.js | 2 +- lighthouse-core/test/audits/errors-in-console-test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lighthouse-core/audits/errors-in-console.js b/lighthouse-core/audits/errors-in-console.js index 942d9142949c..aa71435ef461 100644 --- a/lighthouse-core/audits/errors-in-console.js +++ b/lighthouse-core/audits/errors-in-console.js @@ -44,7 +44,7 @@ class ErrorLogs extends Audit { } /** @return {AuditOptions} */ - static defaultOptions() { + static get defaultOptions() { // Any failed network requests with error messsage aren't actionable return {ignoredPatterns: ['ERR_BLOCKED_BY_CLIENT.Inspector']}; } diff --git a/lighthouse-core/test/audits/errors-in-console-test.js b/lighthouse-core/test/audits/errors-in-console-test.js index 3064f7cf0679..4f800c17a140 100644 --- a/lighthouse-core/test/audits/errors-in-console-test.js +++ b/lighthouse-core/test/audits/errors-in-console-test.js @@ -236,7 +236,7 @@ describe('ConsoleMessages error logs audit', () => { 'url': 'https://www.facebook.com/tr/', 'text': 'Failed to load resource: net::ERR_BLOCKED_BY_CLIENT.Inspector', }], - }, {options: ErrorLogsAudit.defaultOptions()}); + }, {options: ErrorLogsAudit.defaultOptions}); assert.equal(auditResult.score, 1); assert.equal(auditResult.details.items.length, 0); });