Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows user to cache the agent's configuration #82

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

matthv
Copy link
Member

@matthv matthv commented Jan 12, 2024

The previous configuration can't be serialized when a user uses the artisan optimize or artisan config:cache

This PR:

  • add a new configuration file config/forest.php (laravel way)
  • move the previous configuration to an new template fire agentTemplate/forest_admin.php
  • uses only the config() helper rather than the env() helper to call the agent's configuration
  • allows the user to cache the configuration

Copy link

codeclimate bot commented Jan 12, 2024

Code Climate has analyzed commit 4e75ff6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (99% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

@matthv matthv changed the title fix: allows the user to cache the agent's configuration fix: allows user to cache the agent's configuration Jan 15, 2024
@matthv
Copy link
Member Author

matthv commented Jan 15, 2024

Copy link
Member

@nicolasalexandre9 nicolasalexandre9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthv matthv merged commit 8d39c44 into main Jan 16, 2024
6 checks passed
@matthv matthv deleted the fix/config-agent branch January 16, 2024 08:59
forest-bot added a commit that referenced this pull request Jan 16, 2024
# [3.0.0](v2.1.2...v3.0.0) (2024-01-16)

### Bug Fixes

* allows user to cache the agent's configuration ([#82](#82)) ([8d39c44](8d39c44))

### BREAKING CHANGES

* add a new configuration file config/forest.php and move the previous configuration to a new template file agentTemplate/forest_admin.php
@forest-bot
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants