fix(charts): user with permissions level that allows charts creation or edition should always be allow to perform charts requests #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthv
changed the title
|
Code Climate has analyzed commit f9ee038 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (99% is the threshold). This pull request will bring the total coverage in the repository to 100.0%. View more on Code Climate. |
|
Task linked: CU-2xwxdaq Security charts : fix permissions |
Thenkei
reviewed
Sep 6, 2022
Comment on lines
+73
to
+81
| 'id' => $this->data['id'], | ||
| 'email' => $this->data['email'], | ||
| 'first_name' => $this->data['first_name'], | ||
| 'last_name' => $this->data['last_name'], | ||
| 'team' => $this->data['teams'][0], | ||
| 'tags' => $this->data['tags'], | ||
| 'rendering_id' => $this->renderingId, | ||
| 'exp' => $this->expirationInSeconds(), | ||
| 'permission_level' => $this->data['permission_level'], |
| @@ -10,7 +10,6 @@ | |||
| use Illuminate\Http\Request; | |||
| use Illuminate\Support\Facades\Auth; | |||
| use Illuminate\Support\Facades\Gate; | |||
| use Illuminate\Support\Str; | |||
There was a problem hiding this comment.
Nope TBH, I saw that this import was not used by looking at the authorization provider.
This file is used to add Policies for the charts => https://github.com/ForestAdmin/laravel-forestadmin/blob/main/src/Providers/AuthorizationProvider.php#L44-L56
Thenkei
approved these changes
Sep 6, 2022
forest-bot
added a commit
that referenced
this pull request
Sep 6, 2022
## [1.1.3](v1.1.2...v1.1.3) (2022-09-06) ### Bug Fixes * **charts:** user with permissions level that allows charts creation or edition should always be allow to perform charts requests ([#60](#60)) ([b467b35](b467b35))
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
arnaud-moncel
pushed a commit
that referenced
this pull request
Jul 17, 2023
…or edition should always be allow to perform charts requests (#60)
arnaud-moncel
pushed a commit
that referenced
this pull request
Jul 17, 2023
## [1.1.3](v1.1.2...v1.1.3) (2022-09-06) ### Bug Fixes * **charts:** user with permissions level that allows charts creation or edition should always be allow to perform charts requests ([#60](#60)) ([b467b35](b467b35))
forest-bot
added a commit
that referenced
this pull request
Jul 17, 2023
# [1.0.0-beta.24](v1.0.0-beta.23...v1.0.0-beta.24) (2023-07-17) ### Bug Fixes * **charts:** user with permissions level that allows charts creation or edition should always be allow to perform charts requests ([#60](#60)) ([e33a601](e33a601)) * **query-builder:** patch eagerload relationships on collection ([#66](#66)) ([0c1ef79](0c1ef79)) * **relationship:** ignore methods with parameters that return relationships ([#68](#68)) ([99d380a](99d380a)) * **security:** update guzzle version (with dependency) to 7.4.5 ([#58](#58)) ([3b26ebd](3b26ebd)) * **security:** update guzzle version to 7.4.3 ([#52](#52)) ([b32b9db](b32b9db)) * **smart-collection:** add support of smart-relationship ([#63](#63)) ([7b69434](7b69434)) * add database type timestamp for schema generation ([#57](#57)) ([087eaea](087eaea)) * permission to avoid any conflict with laravel policy ([#62](#62)) ([883129a](883129a)) * render jsonapi when a model uses eager load relation ([#61](#61)) ([656500c](656500c)) ### Features * add support for multiple models directories ([#56](#56)) ([bde2f5d](bde2f5d)) * allow to use agent with laravel 10 ([#69](#69)) ([69b01cc](69b01cc)) * allow user to onboard to the new eloquent datasource from forestadmin/agent-php ([#72](#72)) ([09f4822](09f4822)) * **auth:** remove callbackUrl parameter on authentication ([#59](#59)) ([647536e](647536e)) ### BREAKING CHANGES * allow user to onboard to the new eloquent datasource from forestadmin/agent-php
arnaud-moncel
pushed a commit
that referenced
this pull request
Jul 17, 2023
…or edition should always be allow to perform charts requests (#60)
arnaud-moncel
pushed a commit
that referenced
this pull request
Jul 17, 2023
## [1.1.3](v1.1.2...v1.1.3) (2022-09-06) ### Bug Fixes * **charts:** user with permissions level that allows charts creation or edition should always be allow to perform charts requests ([#60](#60)) ([b467b35](b467b35))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security