fix: Offline handler not used as fallback for local evaluation mode during init #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
zachaysan
and removed request for
a team
matthewelwell
approved these changes
Aug 9, 2024
zachaysan
approved these changes
Aug 9, 2024
Comment on lines
+285
to
+286
| except (FlagsmithAPIError, requests.RequestException): | ||
| logger.exception("Error updating environment") |
There was a problem hiding this comment.
Should we early return here?
There was a problem hiding this comment.
The _update_overrides() method does it.
khvn26
deleted the
fix/offline-handler-not-used-as-fallback-for-local-eval
branch
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99.
Note that as part of this change, the
update_environment()method is not supposed to produce HTTP-related exceptions now.