Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Support for SPIR-V < 1.3 (and therefore Vulkan < 1.1) #164

Closed
fu5ha opened this issue Oct 27, 2020 · 0 comments · Fixed by #165
Closed

Tracking: Support for SPIR-V < 1.3 (and therefore Vulkan < 1.1) #164

fu5ha opened this issue Oct 27, 2020 · 0 comments · Fixed by #165
Labels
c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: design Design of our rust-gpu language and std t: tracking issue An issue tracking the progress of a specific feature or change.

Comments

@fu5ha
Copy link
Member

fu5ha commented Oct 27, 2020

Currently, when using shaders compiled with rust-gpu on older Vulkan versions, we get validation errors like in #163. That is fixable for the example in theory by upgrading the Vulkan version to latest, for which there's tracking issues in gfx-rs: gfx-rs/gfx#3146 and gfx-rs/gfx#3302

However, this is probably also a design decision in terms of what exactly the limitations are for older versions of SPIR-V (for example I think a big one is subgroup operations which are only found in Vulkan 1.1/SPIR-V 1.3+) and whether we want to support them or not.
@fu5ha fu5ha added t: design Design of our rust-gpu language and std c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: tracking issue An issue tracking the progress of a specific feature or change. labels Oct 27, 2020
This was referenced Oct 27, 2020
Closed
Closed
@khyperia khyperia mentioned this issue Oct 28, 2020
Merged
@mergify mergify bot closed this as completed in #165 Oct 28, 2020
@XAMPPRocky XAMPPRocky mentioned this issue Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: design Design of our rust-gpu language and std t: tracking issue An issue tracking the progress of a specific feature or change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for spir-v 1.0 EmbarkStudios/rust-gpu
1 participant
@fu5ha