Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deth_ctf - owner can be address(0) #33

Open
ghost opened this issue Aug 12, 2024 · 1 comment
Open

deth_ctf - owner can be address(0) #33

ghost opened this issue Aug 12, 2024 · 1 comment
Labels
invalid This doesn't seem right

Comments

@ghost
Copy link

ghost commented Aug 12, 2024

Description of the Bug:

The constructor of Vault takes an address param _owner which is not checked if it is address(0). Thus, the public state variable owner can be set to address(0)

Impact

Malicious user can create Vaults with wrong address values

Solution:

Check for address(0) when assigning values to address state variables.

@0xdeth
Copy link
Contributor

0xdeth commented Aug 17, 2024

Owner is always msg.sender.

@0xdeth 0xdeth added the invalid This doesn't seem right label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant