Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b0g0_ctf - locked ETH #22

Open
sammy-tm opened this issue Aug 12, 2024 · 3 comments
Open

b0g0_ctf - locked ETH #22

sammy-tm opened this issue Aug 12, 2024 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists partial

Comments

@sammy-tm
Copy link

sammy-tm commented Aug 12, 2024

##Description

If a depositor transfers an NFT to another depositor, and the other depositor withdraws, the ETH from the first depositor gets locked in the contract forever.

Imagine this scenario :

D1 : Deposits and gets NFT 1 and transfers to D2
D2 : Deposits and gets NFT 2
D2 : Burns NFT 1

Now, deposits[D2] will be zero, so even if D2 burns NFT 2, he won't get his deposit back and there is no way to recover this ETH

##Impact

Permanent loss of funds

@X1pherW0lf
Copy link

D2's NFT2 will be stuck as well since his deposit becomes 0 so only way to recover is to D2 sends NFT 2 to D1 and withdraw lol

@BogoCvetkov
Copy link
Collaborator

BogoCvetkov commented Aug 17, 2024

Good one! Valid - first submission for that issue

@BogoCvetkov BogoCvetkov added bug Something isn't working partial duplicate This issue or pull request already exists labels Aug 17, 2024
@BogoCvetkov
Copy link
Collaborator

I'm splitting this between this report and #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists partial
Projects
None yet
Development

No branches or pull requests

3 participants