Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple from Grunt #7

Open
adam-lynch opened this issue Oct 18, 2014 · 2 comments
Open

Decouple from Grunt #7

adam-lynch opened this issue Oct 18, 2014 · 2 comments

Comments

@adam-lynch
Copy link
Contributor

Hey, this looks great! It would be good if there was a plain Node module though. That would make it a lot more accessible. Let's say there would be a new "link-checker" (core) module.

Then this project would have the new "link-checker" module as a dependency, so this would just wrap it for grunt.

Then I could also make a gulp module if that made sense (maybe a Gulp plugin isn't needed; maybe using the plain Node module with gulp on its own would make most sense, I don't know).

Would you be open to that? I had a quick look over the source and it doesn't seem like it would be hard. I'd be up for helping anyway.

@ChrisWren
Copy link
Owner

Hey, sorry for not responding. I think it would be cool to decouple, but this module is really just wrapping the node-crawler module with some handlers specific to checking links. There isn't much code like you said, so it might be best to just copy the code and modify it to work with gulp.

@adam-lynch
Copy link
Contributor Author

Ok cool. I won't have the time soon but I am interested and probably will get to it. I'll let you know 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants