Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_grammatical_expressions shouldn't need universe as argument anymore #45

Open
haberchr opened this issue Sep 28, 2024 · 0 comments
Open
Assignees

Comments

@haberchr
Copy link
Collaborator

It seems now that reading expressions requires again that Universe be specified upon loading them. After an initial refactor of Meaning, it looks like Universe had not been required for loading Meanings for a bit. Since Expressions need a meaning, this means that requiring Universe in Meaning once again means that loading expressions requires defining a Universe in a function that loads / reads the expressions. However, because Expression has a Universe as an attribute, it is saved in the yaml dump and should not need to be specified as an argument in functions that load expressions.

A potential solution could be to load the first Expression's Universe attribute in read_grammatical_expressions and use that instead of passing universe as an argument in that function.

@haberchr haberchr self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant