Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfox-classic fails to build with rust-1.40 #1315

Closed
Polynomial-C opened this issue Dec 20, 2019 · 3 comments
Closed

Waterfox-classic fails to build with rust-1.40 #1315

Polynomial-C opened this issue Dec 20, 2019 · 3 comments

Comments

@Polynomial-C
Copy link

   Compiling encoding_glue v0.1.0 (/var/tmp/portage/www-client/waterfox-2019.12/work/Waterfox-2019.12-classic/intl/encoding_glue)
error[E0713]: borrow may still be in use when destructor runs
   --> /var/tmp/portage/www-client/waterfox-2019.12/work/Waterfox-2019.12-classic/third_party/rust/url/src/form_urlencoded.rs:248:40
    |
246 | impl<'a> Target for ::UrlQuery<'a> {
    |      -- lifetime `'a` defined here
247 |     fn as_mut_string(&mut self) -> &mut String { &mut self.url.serialization }
248 |     fn finish(self) -> &'a mut ::Url { self.url }
    |                                        ^^^^^^^^ - here, drop of `self` needs exclusive access to `*self.url`, because the type `UrlQuery<'_>` implements the `Drop` trait
    |                                        |
    |                                        returning this value requires that `*self.url` is borrowed for `'a`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0713`.
error: could not compile `url`.
warning: build failed, waiting for other jobs to finish...
error: build failed
make[4]: *** [/var/tmp/portage/www-client/waterfox-2019.12/work/Waterfox-2019.12-classic/config/rules.mk:998: force-cargo-library-build] Error 101
@Polynomial-C Polynomial-C changed the title Waterox-classic fails to build with rust-1.40 Waterfox-classic fails to build with rust-1.40 Dec 20, 2019
@Polynomial-C
Copy link
Author

Caused by the following merged rust PR:
rust-lang/rust#64221 (NLL warnings in the 2015 edition are now hard errors)

@hawkeye116477
Copy link
Contributor

If this issue is solved, then it can be probably closed 😄

@Polynomial-C
Copy link
Author

Indeed. No that we have a release that builds with rust-1.40 this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants