Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] PKCE should use 96 random bytes instead of 43 for added security #1777

Closed
bgavrilMS opened this issue Apr 23, 2020 · 2 comments · Fixed by #3503
Closed

[Feature Request] PKCE should use 96 random bytes instead of 43 for added security #1777

bgavrilMS opened this issue Apr 23, 2020 · 2 comments · Fixed by #3503
Labels
Feature Request security
Milestone
4.46.0

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Apr 23, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Defence in depth

Describe the solution you'd like
MSAL's PKCE implementation uses a code verifier of 43 bytes. This is the minimum described in the spec RFC 7636.
To benefit from added entropy, MSAL should use the maximum described in the spec, i.e. 96 bytes

For more details see the comments on this PR https://github.com/microsoft/Git-Credential-Manager-Core/pull/102/files
@henrik-me
Copy link
Contributor

@bgavrilMS : About a year ago we had similar alignment for the state parameter. Should be a relatively simple API PR to ensure all libraries aligns.

@MichelZ MichelZ mentioned this issue Jul 21, 2022
Merged
@pmaytak pmaytak moved this from Triage to Waiting for Code Review in MSAL Customer Trust / QM Jul 22, 2022
@pmaytak pmaytak added this to the 4.46.0 milestone Jul 22, 2022
Repository owner moved this from Waiting for Code Review to Fixed in MSAL Customer Trust / QM Jul 23, 2022
@pmaytak
Copy link
Contributor

pmaytak commented Aug 4, 2022

Released in 4.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request security
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.46.0
Development

Successfully merging a pull request may close this issue.

Increase PKCE Code Verifier Size AzureAD/microsoft-authentication-library-for-dotnet
3 participants
@bgavrilMS @pmaytak @henrik-me