feat: add custom objective function to lightgbm learners #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
b5ba177 to
01c7ac0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
commented
May 20, 2021
src/main/scala/com/microsoft/ml/spark/lightgbm/booster/LightGBMBooster.scala
Outdated
Show resolved
Hide resolved
imatiach-msft
commented
May 20, 2021
src/test/scala/com/microsoft/ml/spark/lightgbm/split1/VerifyLightGBMClassifier.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 84.91% 84.96% +0.05%
==========================================
Files 203 206 +3
Lines 9685 9744 +59
Branches 564 558 -6
==========================================
+ Hits 8224 8279 +55
- Misses 1461 1465 +4
Continue to review full report at Codecov.
|
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
2 times, most recently
from
c59741d to
0ae1fd9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
0ae1fd9 to
392f4a5
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
392f4a5 to
2105d78
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
2105d78 to
79cad0b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
2 times, most recently
from
c25c330 to
a8e6e51
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
previously approved these changes
May 24, 2021
src/main/scala/com/microsoft/ml/spark/lightgbm/booster/LightGBMBooster.scala
Show resolved
Hide resolved
src/main/scala/com/microsoft/ml/spark/lightgbm/booster/LightGBMBooster.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/ml/spark/lightgbm/booster/LightGBMBooster.scala
Show resolved
Hide resolved
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
3 times, most recently
from
99bdb64 to
8359acd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
requested changes
May 24, 2021
src/main/scala/com/microsoft/ml/spark/lightgbm/params/FObjTrait.scala
Outdated
Show resolved
Hide resolved
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
8359acd to
aeafc0f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
previously approved these changes
May 25, 2021
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
aeafc0f to
8355ad0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
8355ad0 to
5470891
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/custom-obj
branch
from
5470891 to
c870b60
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
approved these changes
May 25, 2021
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for custom objective function in lightgbm learners
Users in the scala API will now be able to supply a custom loss function for training, which will need to output the gradient and hessian matrix.
As part of this PR, the LightGBMBooster and LightGBMDataset classes have been improved and moved under the booster and dataset folders, and some of the files related to parameters have been moved to a separate params folder in order to organize the code better since there are so many files in lightgbm directory.
TODO: add pyspark support, in a separate PR