Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue Listener Drain Mode fixes #47791

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Queue Listener Drain Mode fixes #47791

wants to merge 8 commits into from

Conversation

zahalzel
Copy link
Member

@zahalzel zahalzel commented Jan 10, 2025 •
edited
Loading

Two changes to the queue listener:

  1. When drain mode is enabled, we should not trigger the cancellation token in StopAsync
  2. _queueProcessor.CompleteProcessingMessageAsync should only pass in the shutdown cancellation token, not the linked cancellation token

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files) labels Jan 10, 2025
@github-actions GitHub Actions
Copy link

Thank you for your contribution @zahalzel! We will review the pull request and get back to you soon.

@zahalzel
Copy link
Member Author

Related to issue #47427

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 10, 2025 •
edited
Loading

API change check

API changes are not detected in this pull request.

@seanmcc-msft
Copy link
Member

@zahalzel, thanks for contribution. Can you also update the changelog as part of this PR? https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Queues/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@amnguye amnguye Awaiting requested review from amnguye amnguye is a code owner

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft jaschrep-msft is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@fabiocav fabiocav Awaiting requested review from fabiocav fabiocav is a code owner

@mathewc mathewc Awaiting requested review from mathewc mathewc is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@nickliu-msft nickliu-msft Awaiting requested review from nickliu-msft nickliu-msft is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zahalzel @azure-sdk @seanmcc-msft