Gutenberg: Ampersand character (&) in title displays & in editor and message

[alisterscott]

Tested that this happens in both wp-admin and Calypso Gutenberg for a simple site. It didn't happen on Gutenberg master (see screenshot below) or wp-admin on a Jetpack site

Steps to reproduce

1. Starting at URL: https://wordpress.com/post or https://wpcalypso.wordpress.com/block-editor/post for a simple site opted in
2. Type an & character in title and publish (eg. "Black & White")

What I expected

Title in editor and message shouldn't contain & as per Gutenberg core and Calypso Classic

What happened instead

Title in editor and message shows &

Browser / OS version

Chrome 70 on macOS

Screenshot / Video

Calypso:

wp-admin:

Gutenberg Master:

Calypso Classic Editor:

Context / Source

#dogfooding

[mmtr]

This is still reproducible with Gutenframe.

[joweber123]

Another report of this here: 15802960-hc

[gwwar]

Still reproducible on wpcom. This is a wpcom issue only. #27825 may be related

[jeraldjuice]

This is an escaping issue and applies to other entities as well.

The data displayed in the areas affected is coming from the post revision data, which hasn't been normalized like the post data itself is (ie, /state/posts/utils.js). This means that the escaped entities leak through when ultimately displayed in the editor instance in the iframe.

Working on a fix from that angle.

[mmtr]

Maybe related to #38362 which was solved recently in WordPress/gutenberg#19187

[jeraldjuice]

It looks like you're right; I'll open up a PR in Gutenberg for the sidebar link after publish. The revisions escaping issue might be applicable to #27825

[kaitohm]

We have a similar issue happening with apostrophes: 2583624-zen

[mmtr]

It looks like you're right; I'll open up a PR in Gutenberg for the sidebar link after publish.

I think we can apply the same fix than WordPress/gutenberg#19187 and replace unescape with decodeEntities:

https://github.com/WordPress/gutenberg/blob/ab8af23410f9f89f5a57064b43758b157f392d55/packages/block-library/src/navigation-link/edit.js#L83

The revisions escaping issue might be applicable to #27825

Yeah, it could help. But it seems the closing quote gets replaced with an HTML-encoded on the published view, so I wouldn't discard KSES as the cause of #27825.

[gwwar]

Title issue fixed by @glendaviesnz in WordPress/gutenberg#19187. The publish link should be fixed in WordPress/gutenberg#19517

[gwwar]

closing this out for now, we should pick up the other publish link fix in the next update round