Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related Posts: Apostrophes in Titles Renders as HTML Entity Number #14391

Closed
jacoswan opened this issue Jan 20, 2020 · 19 comments
Closed

Related Posts: Apostrophes in Titles Renders as HTML Entity Number #14391

jacoswan opened this issue Jan 20, 2020 · 19 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Related Posts [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jacoswan
Copy link

jacoswan commented Jan 20, 2020

Steps to reproduce the issue

This only seems to happen on WordPress.com simple sites.

  1. Visit any single post page with a Jetpack Related Posts section at the bottom (Twenty Ninteteen, for instance, does this by default)
  2. Edit one of the posts you see in that section, and add a normal apostrophe to the title ( ' )
  3. Save the post you edited, and refresh the single post page where you have the Related Posts section open on
  4. Notice how the apostrophe renders as '

What I expected

I expected an apostrophe '

What happened instead

I got ' instead

Screenshots
Without an apostrophe '

image

With an apostrophe '

image

Issue reported in 2640192-zen, and I as able to recreate this on my own Premium plan with TwentyNineteen active, on Chrome and Firefox.

@jacoswan jacoswan added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Related Posts labels Jan 20, 2020
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 20, 2020
@jeherve
Copy link
Member

jeherve commented Jan 20, 2020

I can't seem to be able to reproduce on my end:

screenshot 2020-01-20 at 10 43 49

screenshot 2020-01-20 at 10 41 59

Which apostrophe did you use in your posts?

' or ?

Could you also let me know if you've set a custom character encoding on your site and / or a custom language, other than utf-8 / en_US?

Thank you.

@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 20, 2020
@jacoswan
Copy link
Author

Images are from standard, Premium-plan sites.
Both site are just the default English as per Manage » Settings » Language
I tested this with English (UK) too, results are the same for me.
No special encoding was selected anywhere (that I'm aware of), sites are just created as per my default WPCOM profile, i.e. English.
My keyboard is standard Apple Extended Keyboard, and my system language is set to English (UK).
I used a ' - the one that sits between ; and \under the right-hand pinky (touch typing)

This image is from a test Premium-plan site: https://jcopremium.wordpress.com/2019/08/11/ratings-blocks/, where the theme TwentyNineteen is active. Related Posts can be toggled via the Tools » Marketing » Traffic » Related posts setting, and looks like this:

image

It's irrespective of "Show a thumbnail image where available" being on/off

image

If I use a Related Posts Block in the editor instead, the block shows the entity in the editor, but renders fine on the front-end, and blocks the built-in Related Posts from showing:

image

image

These images are from a new test Premium-plan site: https://jcoprem2020.design.blog/2020/01/08/example-post/. Active theme is Maywood, which doesn't have Related Posts built in, so ignores the settings you can set in Tools » Marketing » Traffic, but you can use the Related Posts Block in the Editor. In Maywood, the block in the editor also shows the error, but renders fine on the front-end.

Block in the Editor:

image

Front-end:

image

@jeherve

@jacoswan jacoswan removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 23, 2020
@kbrown9
Copy link
Member

kbrown9 commented Jan 28, 2020

I can’t reproduce this on my Jetpack test site. However, I am seeing it on a wpcom site - see p9dueE-1aq-p2.

@samiff
Copy link
Contributor

samiff commented Jan 29, 2020

2668689-zen

Reproduced issue with Twenty Nineteen on wpcom simple site, works as expected on atomic site.

@charliescheer
Copy link

Same problem in 2668839-zen

@tarunvijwani
Copy link

tarunvijwani commented Jan 29, 2020

Same problem in 2669039-zen

@drwpcom
Copy link

drwpcom commented Jan 30, 2020

Possibly related to Automattic/wp-calypso#38362

@jeherve
Copy link
Member

jeherve commented Jan 30, 2020

@damiannep Good catch!

It looks like it's still an issue in Gutenberg at the moment, and may be fixed as of this PR:
WordPress/gutenberg#19955

Let's wait until this lands in Gutenberg, and is then shipped on all WordPress.com sites.

@jeherve
Copy link
Member

jeherve commented Jan 31, 2020

Internal reference: pbAok1-dx-p2

@happychait
Copy link

Another report in 18575571-hc

@arunsathiya
Copy link

2717300-zen

@khristiansnyder
Copy link

khristiansnyder commented Feb 18, 2020

Another report in 13342089-hc

Any posts with ' in the title get that rendered as&#039in the related post list on single post pages. Theme is Hermes and is a simple site.

@iamgabrielma
Copy link
Contributor

Another case here: 2718529-zen . Simple site and theme Publication.

@pauljacobson
Copy link
Contributor

Also reported here: 18925743-hc

@darnelldibbles-zz
Copy link

@happychait
Copy link

Another report in 19283860-hc

@gwensmithx
Copy link

Another report - 2783476zd / 19308983hc

Theme: Twenty Twenty
Site language is English but site interface language is:

Screen Shot 2020-03-11 at 3 52 08 PM

@tijosh
Copy link

tijosh commented Mar 12, 2020

#19358377-hc

Independent Publisher 2

@noahtallen
Copy link
Contributor

This is resolved in the latest Gutenberg version on WordPress.com. Let us know if it continues happening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Related Posts [Status] Blocked / Hold [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests