Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors are shown when --plugin-script plugin fails to import #13

Open
ivan opened this issue Oct 5, 2018 · 1 comment
Open

No errors are shown when --plugin-script plugin fails to import #13

ivan opened this issue Oct 5, 2018 · 1 comment

Comments

@ivan
Copy link
Contributor

ivan commented Oct 5, 2018

The plugin loader should print errors for plugins that fail to import.

No errors are shown even with wpull --debug.

@ivan
Copy link
Contributor Author

ivan commented Oct 5, 2018

https://github.com/tibonihoo/yapsy/blob/434e20f5a19cb14dd2db5aaa333b120803b39e8a/package/yapsy/PluginManager.py#L506-L513

<@JAA>  ivan: Could be this: https://github.com/tibonihoo/yapsy/blob/434e20f5a19cb14dd2db5aaa333b120803b39e8a/package/yapsy/PluginManager.py#L506-L513
<@JAA>  IIRC, the log output from wpull suppresses all messages which don't come from wpull.* loggers.
<@JAA>  Yeah, logging.Filter in wpull.application.tasks.log.LoggingSetupTask._setup_console_logger.
<@JAA>  Although it seems like the file handler doesn't use that filter, so the log file created with --output should contain those lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant