Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is shrinked on Github #66

Closed
poblouin opened this issue Dec 4, 2021 · 6 comments
Closed

Image is shrinked on Github #66

poblouin opened this issue Dec 4, 2021 · 6 comments
Labels
bug Something isn't working triaging Checking the priority and resolvability of an issue or PR

Comments

@poblouin
Copy link

poblouin commented Dec 4, 2021

Summary

The image height is shrinked on Github (markdown) for some reason. I noticed it few days ago, not sure how long it's been like that.

System:
Macbook Air M1 2020
Monterey 12.0.1
Firefox 94.0.2

How To Reproduce

Steps to reproduce the behavior:

Just look at the README of the repo, you can see the issue there. It's the same in my own README. I haven't try the HTML version, only the markdown.

Screen Shot 2021-12-04 at 8 41 24 AM

Do someone have an idea of what is going on or noticed the same issue as I do? I never worked on this project, but I'll try to take some time to investigate and find a fix.

@poblouin poblouin added the bug Something isn't working label Dec 4, 2021
@ABSphreak
Copy link
Owner

Happens on Firefox and Mobile.
#3 & #46.

@ABSphreak ABSphreak added the triaging Checking the priority and resolvability of an issue or PR label Dec 4, 2021
@poblouin
Copy link
Author

poblouin commented Dec 4, 2021

Ah thanks, I wasn't sure that #46 was related.

@poblouin
Copy link
Author

poblouin commented Dec 4, 2021

@ABSphreak Forcing the width and height seems to fix the issue: poblouin#1. You can test using the Vercel URL from the build.

That's not enough though, we would need to dynamically adapt those values based on the content of the card. That's a start, but I don't think I am good enough at CSS + SVG to properly solve it 😅

@ABSphreak
Copy link
Owner

Closed in #68, I think.

@poblouin
Copy link
Author

poblouin commented Apr 21, 2022

@ABSphreak The issue is still present, I still see it on Firefox when I look at the README of the repo.
Screen Shot 2022-04-21 at 7 07 13 PM

@ABSphreak
Copy link
Owner

@poblouin would look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaging Checking the priority and resolvability of an issue or PR
Projects
None yet
Development

No branches or pull requests

2 participants